Handle command button part #10979
Merged
Handle command button part #10979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
sharon-wang
approved these changes
Dec 5, 2025
Member
sharon-wang
left a comment
sharon-wang
left a comment
There was a problem hiding this comment.
LGTM -- working for me!
One question re: support for other part types
Comment on lines
+338
to
340
| } else if (content instanceof vscode.ChatResponseCommandButtonPart) { | ||
| return acc; | ||
| } else { |
Member
There was a problem hiding this comment.
do you think it's worth supporting the other part types we don't currently list here?
positron/src/vscode-dts/vscode.d.ts
Lines 19996 to 20000 in a15f742
Contributor
Author
There was a problem hiding this comment.
I'll open an issue for it. I'm not sure what those parts should look like so I didn't want to add any handling for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #10364
Shiny has responses that include command buttons and they aren't handled by Assistant when it tries to review the chat history.
Release Notes
New Features
Bug Fixes
QA Notes